commit | dcc8f62cca9a82c05d0a70cdaf01d271301702d8 | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Fri May 15 09:55:47 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri May 15 10:22:37 2020 |
tree | f4d31bcf93f1ddb2d49bf82bdf4010e0224625fa | |
parent | 73bd4355b891665829c66e1b83d64bcc29197a16 [diff] |
device orientation: Ensure new reading values are available in tests. Several tests in external/wpt/orientation-event/ have been flaky, especially the Device Orientation ones. The Device Orientation spec implementation in Blink uses its own timer at 60Hz to read from the shared memory buffer updated by the platform sensors, rather than relying on OnSensorReadingChanged() being called by the platform side. The MockSensor implementation in WPT uses window.setInterval() to update the shared memory buffer and simulate a real platform sensor. For some reason, the Mac bots in particular seem to cause those two timers to get out of sync quite often, in which case the Device Orientation implementation might end up reading an older value even though a test has already called setMock{Motion,Orientation}Data() again. Fix it by adding a workaround: in the Device Orientation tests (but not the Generic Sensors ones), we immediately update the shared memory buffer when changing a mock sensor's reading so that the value will always be available to the Device Orientation code. Bug: 1081633 Change-Id: Id12bbfc5c2b2f9dca6127797a95982b208fc4b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199066 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#769207}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!