| commit | 2b417d90d1bd453c262fe3490a7b13f562342f03 | [log] [tgz] |
|---|---|---|
| author | Anders Hartvoll Ruud <andruud@chromium.org> | Wed May 27 10:01:28 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed May 27 10:27:33 2020 |
| tree | 0a76f1228a56aa1665add0222d58ad3a5e69b6c0 | |
| parent | 4d53adfdfb1d6298ac51c6db31256c0c3562659e [diff] |
Make HasBackground/Border flags monotonic There's currently a bug where a transition on an element with appearance can cause these flags to disappear. This is because the cascade is applied (in full) _twice_ for style resolves where the base computed style optimization is not in use: the first apply produces the base computed style, and the second apply is the same as the first apply, except that it also includes animation effects. The problem is that the second apply can reset the flags if there's a transition (for example) for the property or properties to be set in the first apply round. For example, assume there's a regular declaration background-color:green. This causes HasAuthorBackground to be set after the first apply round. Then, in the second apply round, if there's an animation effect on background-color, then CascadeResolver::AuthorFlags will not have kBackground set, since transitions are not author declarations, and therefore the flag will be set back to false. Instead this CL makes the flags monotonic, such that we're not overwriting the flags later. This fixes a regression where artifacts are shown when transitioning UI elements. Note that it may seem weird that transition/animation declarations don't count as author declarations in this context, but this was done to match the old Blink behavior where transitions/animations also had no effect on the flags. Note also that the now-removed logic regarding Find/Reject/etc. in the if-statement is no longer needed. It was there because forced colors mode used a separate StyleCascade instance previously, which made matters a bit more complicated. However, this has since been changed, so the logic can be simplified. Bug: 1086732 Change-Id: I6e588a7e1d6805ab0a59a9a92bec0eb26e7120eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214552 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#772169}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!