| commit | b271f57185d5b6b642d6cde695e36244f9f2a0d8 | [log] [tgz] |
|---|---|---|
| author | Joey Arhar <jarhar@chromium.org> | Thu May 28 18:36:53 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu May 28 19:37:59 2020 |
| tree | 785717bafe8f8e3496c9aac11acc3d6b54659732 | |
| parent | d90c41e355159cb4594587f5266d02f219c0abaa [diff] |
Allow one form to navigate multiple frames consecutively This patch allows one form to navigate two different frames by moving all state associated with the form submission which occurs after the async step as described in [1] from the form element and the form element's document to the target frame being navigated. Despite the spec saying that the task should be stored in the form element, firefox and safari are both able to navigate multiple frames like this. I plan to follow this up with a spec issue. This organization of state reflect what we used to have with NavigationScheduler [2], which was a member of LocalFrame. I decided to use Frame instead of LocalFrame so that we can have the same semantics for form submission regardless of whether we are submitting to a LocalFrame or a RemoteFrame. The effects are observable in this wpt: [3] This patch disables some double-submit tests. These double-submit tests were added to cover http://crbug.com/977882, however, they do so by targeting different frames. This is not the behavior sites which reported the bug had, and the bug will not reproduce with this patch. This patch basically gets us back to the behavior we had before the patch which caused that bug. Any site which relied on the exact behavior in the test would have only been able to do so since http://crrev.com/c/1850358, which was landed 7 months ago. I plan to follow up and try to get the test passing again in this bug: http://crbug.com/1087077 [1] http://html.spec.whatwg.org/C/#plan-to-navigate [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/forms/html_form_element.cc;l=519-520;drc=8f4e07de2e8797821a9446eb66ceeb305d763cbf [3] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/external/wpt/html/semantics/forms/form-submission-0/form-double-submit-to-different-origin-frame.html Bug: 1085097, 1047489 Change-Id: I1a212e52ef95449c5a0527d5530efaa49d384037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212458 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#772785}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!