commit | c4fef962c5d98c16f212f768896188824500d41b | [log] [tgz] |
---|---|---|
author | Raymond Toy <rtoy@chromium.org> | Tue Jun 16 23:39:17 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jun 17 00:05:04 2020 |
tree | 5151e03f96c7b6407f991e804dc4970127c59654 | |
parent | 774dc6b89e128d2b95f38c8b191ca10c47df292f [diff] |
Vectorize DelayNode processor for k-rate delays Instead of processing the data one sample at a time, we can process a block at a time by doing large memcpy's and then some vector operations to interpolate the samples. As a final micro-optimization, if the interpolation factor is 0, we can skip the interpolation phase altogether. Using (a slightly modified) Spotify's Web Audio Bench, we have the following results using 500 runs of 10 sec each (the default) on a linux machine: Without CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 594 594 740 751 761 3215 757.82 146.55 Delay-default 331 331 387 405 416 2124 406.47 81.65 Delay-0.1 344 344 401 423 440 834 425.68 41.04 DelayAutomation-a-rate 675 675 748 763 779 1262 768.23 42.97 DelayAutomation-k-rate 365 365 424 444 460 1036 446.24 38.61 With CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 736 736 747 756 765 901 758.57 17.76 Delay-default 180 180 230 249 267 1467 256.75 77.1 Delay-0.1 233 233 302 317 332 2402 322.39 96.86 DelayAutomation-a-rate 612 612 683 698 713 983 701.78 33.85 DelayAutomation-k-rate 206 206 281 299 318 522 305.34 37.96 As we can see, the CL speeds up processing the default by 38%, delay-0.1 25% and k-rate by 32% (using the mean and not us results). One layout test needed to be updated to handle numerical differences for mac. The implementation of Vsma on mac is different from linux and windows. and this difference shows up in the test. (Mac uses VDSP_vsma, instead of our hand-written Vsma. VDSP_vsma might be using an FMA which has different round properties.) Bug: 1087071 Change-Id: I2b95096fef9fd1e5f7c87e4f4bdfa7d52f5b8d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171843 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779062}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!