commit | c28b441d5378bb8d669b684a6a8bbb1a24c2482c | [log] [tgz] |
---|---|---|
author | Piotr Bialecki <bialpio@chromium.org> | Thu Jun 11 20:47:07 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Jun 11 22:16:54 2020 |
tree | d558ed0afa20f8ec046f3c9a4d3d1f1f95f92403 | |
parent | 6ab9bc3dfe6eab2056d3d512f4914b3c6a825eb8 [diff] |
WebXR - anchors - fix anchor creation from hit test Anchor creation based off of hit test result was incorrectly using unstable native origin (planes' origins may change diametrically from frame to frame) - this CL fixes the issue. Additionally, hit test logic did not correctly treat hit test results as computed based off of plane intersection - the issue did not cause any problems with hit test API, but is problematic for anchor creation API. Changes: - plane-attached anchor creation now accepts native origin information and pose relative to passed in native origin - this is done to ensure that anchor creation uses a frame of reference that is stable w.r.t. the environment (plane pose is not a correct choice as it changes when plane extents are changing) - fixed an issue in ArCoreImpl::RequestHitTest() - it would not report results as computed based off of a plane even if they were - mojom's hit test result now uses pose instead of matrix - pose is directly provided by ARCore SDK and has smaller cognitive load as it does not require considering column-major vs. row-major memory layouts - IDL - anchor creation based on hit test result and on plane no longer accepts initial pose since the spec draft has changed - initial pose was considered confusing and unnecessary since it did not extend the capabilities of the API - JS-exposed anchor creation from XRHitTestResult and from XRPlane no longer accepts an XRRigidTransform - the spec draft was already changed to account for this All other changes (parameter renames, comment updates, fixing call sites to account for parameter count changes, etc.) are related to the above major changes. Change-Id: I5acb872c5a9d9003f1f85173edd82e6e6fa002bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236592 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#777463}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!