| commit | dbc170ad1cb622a0e49b3a35f5a246fdbacf2a45 | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Mon Jun 22 13:00:50 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Jun 22 13:39:25 2020 |
| tree | 7bf1097887b2f06dafb5aee3c2a7803ad4d33630 | |
| parent | ac1579d8f1162706e77a1ff68cef49c5a871dd60 [diff] |
[LayoutNG] Truncate block-end child margins at fragmentainer boundaries. This was almost working correctly even without this fix, because we currently just brutally break inside a block that overflows if there are no breaks inside, losing any trailing margins. The only problem currently, is that such a break still produces a break token, so that the broken block would resume in the next fragmentainer (even if there's nothing left to lay out), producing no content there, but an empty fragment would create a break opportunity that shouldn't really be there. This was a problem both for regular block containers and fieldsets. This CL fixes that. It's also a problem for column spanners if they participate in an outer fragmentainer context, but we have some underlying issues there, so I just added a TODO. The -001.html test wouldn't even fail without this CL, but as I'm working on fixing the aforementioned brutal breaking, I felt we need slightly better test coverage. The new function AdjustedMarginAfterFinalChildFragment() is extremely simple, and the amount of code duplication it prevents is negligible (or even non-existent). Still, it seems reasonable to provide this function, for the sake of visibility, as this is something that all algorithms need to implement, if they want to get block fragmentation right. Bug: 829028 Change-Id: Ide568f6eaad38cd07e3cfc164bb97745a751fbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252042 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780742}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!