commit | dc5ccc33c13a82e7d2cdf47a39187c72fc64cf47 | [log] [tgz] |
---|---|---|
author | Dominic Farolino <dom@chromium.org> | Fri Jun 26 18:40:30 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Jun 26 19:03:24 2020 |
tree | 08738d3ea8d105e639ad1a5472ecb228f1f993b9 | |
parent | 30184b0c90f0b7f16eaa6deb5d21d35daa0e5fa9 [diff] |
Implement list of available images matching logic This CL makes ImageLoader::ShouldLoadImmediately perform a stricter check, such that we skip queueing the image loading microtask less often. The stricter check we perform is equivalent to the HTML Standard's list of available images tuple-matching logic [1]. This changes the image loading behavior for cases where an image request is made for a resource that is in the MemoryCache, but has a different CORS settings attribute / credentials mode. Consider the following, which are all requesting the same image: - An image resource was fetched with CORS settings attr B, and is in the MemoryCache / list of available images - An image request (1) for the same resource is made, with CORS settings attribute A - An image request (2) for the same resource is made, with CORS settings attribute B Prior to this CL, request (1) would skip queueing a microtask, because ImageLoader::ShouldLoadImmediately would naively consider the cached resource a match. The request would go the ResourceFetcher, and ResourceFetcher::DetermineRevalidationPolicyInternal would realize a cache miss, because the CORS settings attributes did not match. The ResourceFetcher would add the resource that was fetched with CORS settings attribute A to the MemoryCache. Then request (2) would be made, and the server would see both requests (1) and (2). After this CL, ImageLoader::ShouldLoadImmediately is more strict, implementing the same CORS settings attribute check that ResourceFetcher::DetermineRevalidationPolicyInternal does. ImageLoader queues a microtask for request (1). Then, request (2) is kicked off before the microtask is run, and requests (1) and (2) are coalesced. The server only see one (correct) request. [1]: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:list-of-available-images R=yoavweiss@chromium.org Bug: 1093977 Change-Id: I3ca9a3cf63177572a8f45fa6be8a3b0c25f9c539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244191 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#783065}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!