commit | d33bc572d46eab7d3db2f67c24ab7e132344e22f | [log] [tgz] |
---|---|---|
author | Alison Maher <almaher@microsoft.com> | Mon Jul 06 18:26:41 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Jul 06 19:25:26 2020 |
tree | 50b7d74fe8098aa12e7deb3f3ebfd9889a681f08 | |
parent | 1f53c57f1b474d7877184d45b32b583b88b5c6af [diff] |
Reland "Don't reset computed 'float' for flex and grid items" This is a reland of 906abd41e4f6c786a1927f6edd69d6926e20317b Original change : https://chromium-review.googlesource.com/c/chromium/src/+/2157889 Revert of original change : https://chromium-review.googlesource.com/c/chromium/src/+/2256772 ----- The original change was reverted due to a DCHECK being triggered. See the following CRBug for more details: https://bugs.chromium.org/p/chromium/issues/detail?id=1097595 The original change no longer adjusted the ComputedStyle for floats based on whether or not it was a flex/grid item. This adjustment was left for the LayoutBox to handle. However, there was code on the layout side that depended on IsFloating() getting adjusted for the style, as well. This resulted in the DCHEK mentioned above getting hit. To fix this, I updated all cases that used the style's IsFloating() function and either updated it to also take the style's IsFlexOrGridItem() function into account or updated the code to use LayoutObject's IsFloating() function instead. ----- Original change's description: > Don't reset computed 'float' for flex and grid items > > Floated flex and grid items have their 'float' incorrectly computed to > "none". This change fixes this by adjusting IsFloating() for flex and > grid items inside LayoutBox::UpdateFromStyle() instead of inside > StyleAdjuster::AdjustStyleForDisplay(). > > Beyond this, legend elements are not allowed to be rendered legends > if they are floating. However, if legends are flex items, we > adjust IsFloating() to be false. This causes legends to be > used as rendered legends when they are flex items, even if they > were styled as a float. > > This is fixed by checking ComputedStyle::IsFloating() instead > of LayoutObject::IsFloating() when finding the rendered legend in > order to get its non-adjusted floating value. > > Bug: 875235,350505 > Change-Id: Ia1e7f7c244cc0c443cd58be42854866884b7f7e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157889 > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Commit-Queue: Alison Maher <almaher@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#763988} Bug: 875235, 350505 Change-Id: I915e045db7fda94d99cfdae33911d8b5f6df26de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261412 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#785456}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!