commit | 3d92704499a679683fb03500ceeeaef6ad652676 | [log] [tgz] |
---|---|---|
author | Xianzhu Wang <wangxianzhu@chromium.org> | Mon Jul 06 17:41:01 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Jul 06 18:46:49 2020 |
tree | 3c15f12ab54cfe3d06a55ecd88ea7841929ca4e3 | |
parent | c27fba52a8b09520b9ab38836acb3866f85b4d7d [diff] |
Unify most clip-path code paths of pre-CAP and CAP Previously in pre-CAP, because we always created a composited mask layer for any mask and/or clip-path (either path-based or mask-based) if the object needed to be composited, we needed to handle clip-path differently in pre-CAP and CAP, Now always apply path-based clip-path after paint. No longer create a mask layer for path-based clip-path in pre-CAP. Rename ClipPath to ClipPathMask to make it clear that this effect node is for the mask created for a mask-based clip-path. If there are both mask and mask-based clip-path, always let ClipPathMask effect node be the child of the Mask effect node. This is required by pre-CAP (unchanged) to apply the clip-path in the mask layer, but also works in CAP (previously both Mask ClipPathMask were directly under Effect) because: DstIn(DstIn(A, Mask), ClipPathMask) == DstIn(A, DstIn(Mask, ClipPathMask) where ClipPathMask is black-and-white. If there is only a mask-based clip-path, we'll only create ClipPathMask for both pre-CAP (now no Mask and MaskClip nodes) and CAP (unchanged). The pre-CAP mask layer will use ClipPathMask as the effect state, which avoids the need of filling a black mask before applying the clip path mask. Now the only difference between pre-CAP and CAP about clip-path is that that when a LayerObject with mask-based clip-path is composited, pre-CAP creates a GraphicsLayer for the clip-path mask before paint, while CAP creates a cc::Layer for the mask after paint. Bug: 1100224 Change-Id: I243e463b3c94e09b64ed3c171ece12145c9deec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274177 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#785435}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!