commit | 421cc5ec61be5d407336a446b4da473c889ce518 | [log] [tgz] |
---|---|---|
author | Ian Kilpatrick <ikilpatrick@chromium.org> | Fri Jul 17 23:16:06 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Jul 18 00:06:39 2020 |
tree | 71026b1acddc2f1bdbc7cd68264385f6fe30068f | |
parent | f140180e49e4f8aed5960855947c4273bbefd9eb [diff] |
Reland "[LayoutNG] Move relative position calculation into NG." This reverts commit d73ae868f77e2589c7a563147722c9771bc91717. The issue which caused the bot failures was due to a difference in logic between 32bit, and 64bit arch. See: https://chromium-review.googlesource.com/c/chromium/src/+/2304143 This patch has remained unchanged except for part which landed before to fix another unrelated issue. See: https://chromium-review.googlesource.com/c/chromium/src/+/2304659 Original change's description: > Revert "[LayoutNG] Move relative position calculation into NG." > > This reverts commit 27880cb4012f7a84f7921c1bc3f023211eb032ea. > > Reason for revert: > > Suspect of blink_web_tests failures in a lot of bots, like this one: > > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/70261 > > Unexpected Failures: > * fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html > * fast/css/relative-positioned-block-nested-with-inline-parent.html > * paint/invalidation/compositing/composited-float-under-composited-inline-individual.html > * paint/invalidation/compositing/composited-float-under-composited-inline.html > * paint/invalidation/compositing/stacked-float-under-composited-inline.html > > Original change's description: > > [LayoutNG] Move relative position calculation into NG. > > > > This patch moves the relative position calculation into NG. Previously > > we needed to manually account for the relative position of an object > > in many different places, overflow calculation, geometry APIs etc. > > > > This patch directly updates the child's offset (relative to its parent) > > to directly incorporate this additional offset. > > > > This calculation occurs within the NGBoxFragmentBuilder, and if an > > object is *placed* by LayoutNG... > > ...LayoutBoxModelObject::RelativePositionOffset returns an empty offset. > > > > This fixes a few small issues where previously we didn't resolve > > percentages against the correct available size when contained within > > an anonymous block. > > > > Bug: 1070822, 1058690 > > Change-Id: I2c623b02cc5a4605d310596f5c60353a21236bff > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214608 > > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#787991} > > TBR=yosin@chromium.org,wangxianzhu@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,yosin@google.com,mstensho@chromium.org > > Change-Id: I5ca67701222509693d3020fa068c279cef39ecbb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1070822, 1058690 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296628 > Reviewed-by: Jian Li <jianli@chromium.org> > Commit-Queue: Jian Li <jianli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788228} Bug: 1070822, 1058690 Change-Id: I85a51c06d47c9eb451e8e7b77418913e288b7758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300667 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789685}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!