commit | a8f5298fb676a2c33a1fe60a18fd2ba627788872 | [log] [tgz] |
---|---|---|
author | Nicolás Peña Moreno <npm@chromium.org> | Tue Aug 04 20:21:41 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Aug 04 21:40:10 2020 |
tree | 91a6f31e2510e900e95993313abe08de7b4f8274 | |
parent | af4aba71a5d7d993e1fe4db51478e72b6657ef13 [diff] |
[LCP] Ignore paints with opacity 0 This changes the opacity 0 paints that are ignored by the LCP algorithm. Before, paints that would later be composited were not ignored, which resulted in an inaccurate metric due to detecting LCP too early. After this change, even will-change opacity paints are ignored, which could result in elements not becoming candidates because they are never repainted. In the special case where documentElement changes its opacity, we consider the largest content that becomes visible as a valid LCP candidate. In other words this CL does the following 3 changes: 1) Ignores all LCP signals under style.opacity: 0, as before styles with 'will-change: opacity' were not ignored. 2) Saves off the LCP for ignored LCP signals if they are under non-nested style.opacity = 0. 3.) If the document opacity style changes from opacity: 0 to non-zero, we record the saved off LCP signal. Bug: 1092473 Change-Id: I2a970a34fdb1db6c7c746060c286077553b816a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316788 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794689}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!