commit | 43899f53083e4e6285d7a55d66745d8f6518950d | [log] [tgz] |
---|---|---|
author | Peter Kasting <pkasting@chromium.org> | Sat Aug 01 07:44:13 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Aug 01 08:01:07 2020 |
tree | c06ceb45212254eb879bc07a8739bda2f6733f2f | |
parent | 0e4384b535a085db740a733b89bce098d7c700f4 [diff] |
Revert "Origin isolation: a new strategy for window.originIsolationRestricted" This reverts commit 7ac0b9ed68d57270b680e39b9e21e1ede1b8c774. Reason for revert: Possible cause of flaky navigation/error-related test failures on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests and https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8873201719841161216/+/steps/content_browsertests_on__none__GPU_on_Mac_on_Mac-10.10/0/logs/Flaky_failure:_All__x2f_NavigationControllerBrowserTest.ErrorPageReplacement__x2f_0__status_CRASH_SUCCESS_/0 and https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8873205275892139456/+/steps/storage_service_unsandboxed_content_browsertests/0/logs/Deterministic_failure:_All__x2f_SitePerProcessIgnoreCertErrorsBrowserTest.SubresourceWithCertificateErrors__x2f_0__status_FAILURE_/0. If this revert does not help, I will reland. Original change's description: > Origin isolation: a new strategy for window.originIsolationRestricted > > In https://chromium-review.googlesource.com/c/chromium/src/+/2243994 I > introduced an implementation for window.originIsolationRestricted which > pipes the isolation state from NavigationRequest to the navigated-to > LocalDOMWindow. However, this does not work for the case of the initial > about:blank, where no navigation is performed. Furthermore, it does not > match the spec, where the Window property just reflects an agent > cluster-wide property. > > This CL introduces an alternate approach, more similar to what is done > for self.crossOriginIsolated in > https://chromium-review.googlesource.com/c/chromium/src/+/2247463, which > is another agent cluster-wide value. The origin isolation state is > stored in the renderer-side Agent class. Then the LocalDOMWindow getter > can just pick it up from the surrounding agent, as in the spec. Note > that unlike the implementation for self.crossOriginIsolated, the value > is per-Agent instead of static (process-wide). > > Currently the value is set several times per agent (roughly once on > every navigation). This is redundant, but we don't yet have a good place > to set it once (i.e., we don't have a browser-side "time of agent > creation"). If that gets fixed, we can likely stop piping the value > through navigation params. See > https://docs.google.com/document/d/1MTnmyWAoAIKDH4yWaRthIUdi05MsjlML8gctvKP7-h8/edit > for discussions around fixing that. > > This fixes the issue with about:blank iframes embedded in origin-isolated > pages reporting false, because the agent's origin-isolated boolean was > previously set to true by the containing frame. > > This does not yet fix the issue with data: URLs reporting false, tested in > external/wpt/origin-isolation/getter-special-cases/data-url.https.html. > However, that will be doable as a followup, by changing the > navigation-time computation to pass true for them instead of false. > (Currently it passes false because data: URLs don't get their own > process, but it should pass true because they _do_ get their own agent > cluster.) > > Bug: 1095653 > Change-Id: I8dfa8fc4a4766efc0611d43a255673662c422776 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300237 > Commit-Queue: Domenic Denicola <domenic@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793799} TBR=dcheng@chromium.org,creis@chromium.org,alexmos@chromium.org,domenic@chromium.org,wjmaclean@chromium.org Change-Id: Ia9174b00ac61178cff9bf24801182d23779399c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1095653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333651 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#793885}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!