commit | 5f511c0b931bcdead0eea9f9c9921eef6a9798b8 | [log] [tgz] |
---|---|---|
author | Kevin Ellis <kevers@chromium.org> | Fri Aug 07 15:34:52 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Aug 07 16:34:01 2020 |
tree | 9fe279f25a152e0d9641a42920a1dfe211ab4134 | |
parent | 8520ad6dddfc7d55ad434fd2088378e62568833c [diff] |
Address timeouts in composited CSS animations event dispatch test There are no restrictions on how quickly the client agent needs to respond to a pending play-state change. For non-composited animations the ready promise is resolved on commit of the animation frame; however, for a composited animation, the process is delayed until receiving a start-time notification from the compositor. The event dispatch test previously waited up to 2 animations frames, which is adequate for non-composited tests since the events trigger on the next frame. For composited tests, we need to first wait for the animation to be ready if in a pending state. Once the ready promise is resolved, a two frame time limit is sufficient for the remainder of the steps. Tested with 300 repetitions of the flaking tests in the virtual/threaded environment. Bug: 1064065 Change-Id: Ic4975d5885d3513c5c1b53d755757c0adcc027c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341803 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#795918}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!