| commit | 3287920e1bcd6b82213fdc29fe5b8dbfa0519fac | [log] [tgz] |
|---|---|---|
| author | Ting-Yu Lin <tlin@mozilla.com> | Sat Aug 08 01:22:45 2020 |
| committer | moz-wptsync-bot <wptsync@mozilla.com> | Sat Aug 08 14:01:24 2020 |
| tree | 927d82815c81c332f32ebe71afa172e926acbd50 | |
| parent | 7d187abfafc8910e2cecc76df38abe12e90b4b48 [diff] |
Part 4 - Reflow lines with pushed floats under constrained available block-size or in paginated context. When a clearance frame is discovered in a BFC subtree (`ReflowInput::WillReflowAgainForClearance()` is true), all the block descendants of the BFC return from `ReflowBlockFrame` immediately without placing their children or requesting continuation for their children, etc., because the BFC is going to reflow the subtree a second time. When this happens, any block descendant whose lines contain pushed floats should be marked dirty and reflowed again so that they can go through all the split floats logic and set their nsReflowStatus to incomplete/overflow-incomplete correctly. (We may develop a smarter way in bug 851629 to make the performance better.) The condition `aState.mPresContext->IsPaginated()` is added to prevent 1406291-1.html from failing. In 1406291-1.html, the table containing the float in its subtree is being pushed to the second page due to force break, and the float is in PushedFloatsList of its parent block. When we reflow the block again (in the second page), it is reflowed under the measuring stage of the table layout with unconstrained available block-size. nsBlockFrame::DrainSelfPushedFloats() deliberately doesn't drain pushed floats if their placehoder are in the same block, and expect the floats to be reflowed again. Before this patch, the line can be marked dirty via HasPushedFloats(), but in this patch, HasPushedFloats() is moved into the nested if-else, so we need `aState.mPresContext->IsPaginated()` to let the block know that it's in a paginated context, and needs to reflow any line that contains pushed floats. Differential Revision: https://phabricator.services.mozilla.com/D85480 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1559961 gecko-commit: db613effb20bfd4e703c164d2f464cc22b97e2a8 gecko-integration-branch: autoland gecko-reviewers: dholbert
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!