commit | 392793004f49b07eb813b2c600ef438d4b176524 | [log] [tgz] |
---|---|---|
author | David Bokan <bokan@chromium.org> | Tue Aug 18 17:52:45 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Aug 18 18:34:56 2020 |
tree | b8337b0f96bd5279d1bd22594653be3ad1059dfc | |
parent | cc1b58784ba7ab62924f0e81e062ceaec7834876 [diff] |
Enable text fragments across redirects A text fragment occurs in a URL fragment and begins with ":~:text=...". It is used to highlight and scroll the provided text into view when the page is loaded. For user privacy reasons, we restrict scrolling the text into view unless the navigation occurred via a user gesture. See: https://github.com/WICG/scroll-to-text-fragment#security-considerations for more details. However, it is common (particularly on social and messaging services where content is user-generated) for links to be served via a redirect. A typical example (from chat.google.com) works like this: 1. User receives and clicks a link to https://example.com#:~:text=foo" 2. chat.google.com opens a new tab using window.open("", "_blank") 3. chat.google.com calls document.write on the newly opened window to write a <meta> tag-based client redirect to google.com/url?url=https://example.com... which is the URL redirection service with the destination URL as a query param. 4. google.com/url then calls window.location and writes "https://example.com#:~:text=foo" into it 5. the new tab finally navigates to example.com The only navigation that had a user gesture attached to it is the initial empty document navigation in step 2. This means the example.com page is navigated to without a user gesture and the text fragment is blocked. A similar pattern is seen on many popular services: Twitter, Instagram, Facebook Messenger, etc. This CL solves the above scenario by introducing a "text fragment token". This token grants its holder permission to invoke a text fragment. The token can be used during load to invoke the text fragment, or it can be passed into a navigation to grant permission to the next page without requiring a user gesture. However, in either case, the token is consumed so a page cannot both invoke a text fragment and pass the token. The token is created in only in DocumentLoader's constructor and while processing a same-document navigation. For regular navigations, it is only created if the current navigation was user initiated. For same-document navigations, it's created only if browser-initiated and the navigation has a text fragment. This mechanism can be thought of as a user gesture that applies only to text fragment and whose lifetime extends across navigations but cannot be copied and is always consumed on use. Bug: 1055455 Change-Id: Icddd849937d24b579bbeb5a4b9f87539d8339905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159324 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799173}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!