commit | e4b1b97671ed9e404d7d4cc58237b28711501071 | [log] [tgz] |
---|---|---|
author | Henrik Boström <hbos@chromium.org> | Thu Aug 27 06:48:41 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Aug 27 07:11:09 2020 |
tree | 28e87cbf3aff4a6c40e9757e3c89a1c9f826c493 | |
parent | a18247887493f153823ed7d9d85126bd55668bc1 [diff] |
Revert "[Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time."" This reverts commit 3dbd8ec27d4b3dbf0b53d534a3a180886196361f. Reason for revert: I don't think this is the culprit and it looks like this test has been flaking for a couple of weeks, see: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWAsSBUZsYWtlIk1jaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L3dlYnJ0Yy9wcm90b2NvbC9jcnlwdG8tc3VpdGUuaHR0cHMuaHRtbAw More details here: https://bugs.chromium.org/p/chromium/issues/detail?id=1122106 Original change's description: > [Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time." > > This reverts commit 3bc91ccc927f8eb887a84a1e59f34c88518ce2ab. > > Reason for revert: Failure of WebKit Linux ASAN build, and that's the suspect for root cause. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/17329 > > Original change's description: > > [Perfect Negotiation] Surface session descriptions at the right time. > > > > This fixes another timing related issue that blocks Perfect Negotiation. > > > > Before this CL, current/pending local/remote description attributes do > > blocking-invokes on the webrtc thread, fetching the most up-to-date > > states. This can prematurely expose the result of "in-parallel" > > operations that have not surfaced yet, such as: > > - setLocalDescription > > - setRemoteDescription > > - addIceCandidate > > > > This CL fixes that by copying the SDP states when any of these > > operations complete on the WebRTC thread and carry them over in the > > PostTask to the main thread. Here, we store these snapshots in > > "internal slots" (variables living on the main thread). With this CL, > > reading SDP attributes from RTCPeerConnection is non-blocking and > > spec-compliant. > > > > WPT test coverage added for the exact timing of SLD/SRD and other test > > expectations are updated. addIceCandidate updating the SDP is already > > covered by old WPTs. > > > > Bug: chromium:1110347 > > Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359 > > Commit-Queue: Henrik Boström <hbos@chromium.org> > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801798} > > TBR=hta@chromium.org,hbos@chromium.org > > Change-Id: I4af12fd1430773ea3d134cfc37b9c5e736f20ed0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1110347 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377715 > Reviewed-by: Amr Aboelkher <amraboelkher@google.com> > Commit-Queue: Amr Aboelkher <amraboelkher@google.com> > Cr-Commit-Position: refs/heads/master@{#801822} TBR=hta@chromium.org,hbos@chromium.org,amraboelkher@google.com Change-Id: Ia0f82e0d1b4660cf0d3641aaa446127092c6e6f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1110347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379192 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#802114}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!