commit | e22aecde1ab162b1d7fc793be42a4661fb04efea | [log] [tgz] |
---|---|---|
author | Matt Wolenetz <wolenetz@chromium.org> | Wed Sep 23 23:16:03 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Sep 24 00:16:30 2020 |
tree | 91ce0448859c5ece93c8d8ce5ccbe01d4c0889e3 | |
parent | 1debe1baefede945ac06df5b595f876fe818f019 [diff] |
MSE-in-Workers: Cross-thread registry with stubbed attachment Introduces a concrete CrossThreadMediaSourceAttachment with minimum implementation necessary to enable worker thread MediaSource object URL creation. To enable registration of worker-thread MediaSource object URLs, which is inherent in the createObjectURL implementation, updates MediaSourceRegistryImpl to perform registration and unregistration while holding a mutex in the singleton, main-thread-owned, registry instance. Mutexes previously were thought unusable for this, but that was due to the registry previously using an Oilpan HeapHashMap bound to the main thread's Oilpan heap. The current registry now uses a non-Oilpan HashMap, so any thread can update the singleton so long as such accesses or updates are mutex-protected. Also, using cross-thread task posting to perform these tasks led to complex races whose solution is much simpler using the mutex approach herein. See CrossThreadMediaSourceAttachment::Unregister() for more detail. Includes a necessary update which makes both types of attachments manage the registered media source in appropriate Oilpan type: the cross thread attachment must hold that reference as CrossThreadPersistent. The URL registry implementation already unregisters all entries created on an execution context if that context is destroyed, so this CrossThreadPersistent registry entry will not outlive the worker thread's context. See PublicURLManager::ContextDestroyed() for where that logic exists already. Rationale for not also making the SameThreadMediaSourceAttachment use a CrossThreadPersistent type is that such type introduces a new root in all Oilpan heaps, and resulting performance hit can be avoided by just using regular Persistents for same thread attachments' |registered_media_source_|. Includes new web_tests that exercise basic worker context MediaSource construction, object URL creation and revocation (with revocation of worker MediaSource object URL also tested on main thread). Starting an attachment to a worker MediaSource is also tested, but is currently expected by the test to fail until upcoming CrossThreadMediaSourceAttachment changes land. BUG=878133 Change-Id: I367b6610da9aca3aca7c78f4a11f571e48afc6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407075 Reviewed-by: Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#810002}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!