commit | 3782f5a3f63bb94bb0f8422e222e5cf6738bba7c | [log] [tgz] |
---|---|---|
author | David Grogan <dgrogan@chromium.org> | Fri Oct 16 22:15:12 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Oct 17 00:15:46 2020 |
tree | cc6dc408e453486832056d3f636aff6b7cd230f6 | |
parent | 91376d70bde4173790a6b4bd5098e32261975825 [diff] |
[css-flex] Fix min-height: auto for replaced elements min-height: auto had been using the image's natural height as the content size suggestion, ignoring a specified definite inline size, but according to this spec chain, the specified definite inline size should transfer through the aspect ratio and affect the min-content size. https://drafts.csswg.org/css-sizing-3/#min-content -> https://drafts.csswg.org/css-sizing-3/#intrinsic-sizes -> https://www.w3.org/TR/CSS2/visudet.html#float-replaced-width -> https://www.w3.org/TR/CSS2/visudet.html#inline-replaced-width -> """ if 'width' has a computed value of 'auto', 'height' has some other computed value, and the element does have an intrinsic ratio; then the used value of 'width' is: (used height) * (intrinsic ratio) """ This fix also made clear that the regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/2333530 was not so harmless -- the issue wasn't a wrong test in align-items-007, but rather an incorrect block size given to a replaced element with aspect ratio but no size in the content size suggestion. We had been giving such element a 150px intrinsic block size; the correct size is the available inline size passed through the aspect ratio. This is now fixed in this patch. The changed case at the end of flex-aspect-ratio-img-column-011.html was asserting the opposite behavior of flex-minimum-height-flex-items-007.xht (Gerrit or something keeps adding a bogus "fixed" line under Change-Id, in case this CL shows up someplace random) Change-Id: I05cb4b3ca796b3df02dfa5d8e3790d6164213be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462574 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818100}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!