commit | a4d3b113bd16fad63c3f32d557dd5b2bc401eba7 | [log] [tgz] |
---|---|---|
author | Antonio Sartori <antoniosartori@chromium.org> | Tue Oct 27 16:52:41 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Oct 27 18:12:44 2020 |
tree | 256b9d6ae7b15bb436f6f39591248d6625254a4d | |
parent | 91da84149d57c560e3435866fd198d1910c22e3f [diff] |
Fix referrer policy inheritance WPT for javascript: URLs According to the specification, executing a javascript: URL in a document does not commit a new document. Indeed, following https://html.spec.whatwg.org/multipage/browsing-the-web.html#javascript-protocol executing a javascript: URL request gives a response whose status is 204, and processing a response with status 204 does not commit a new document: https://html.spec.whatwg.org/multipage/browsing-the-web.html#process-a-navigate-response In particular, executing a javascript: URL does not change the document's URL. So if we create a new (empty) iframe and execute right away some javascript: URL in it, the URL of the iframe document will be "about:blank". On the other side, a document with URL "about:blank" will usually not send any Referer header, since the algorithm for determining the outgoing referrer goes through the stripping section https://w3c.github.io/webappsec-referrer-policy/#strip-url which returns `no-referrer` for a local scheme. As a consequence, we should always expect the Referer header of an outgoing fetch request from an `<iframe src="javascript:...">` without custom referrer to be empty. This CL adjusts the referrer policy inheritance WP test to that. Still, we want to test that the referrer policy is inherited correctly for javascript: URLs. For doing that, we add a custom referrer to the outgoing fetch request, and we check that the content of the received Referer header corresponds to the custom referrer modulo the inherited referrer policy. Change-Id: Ib3fe0808d3f8a1790e3f565cf2b1648fd2ea6c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464930 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#821284}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!