commit | 19a95dafe3e474641a889cc2fea6c071c21a7dfb | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Fri Oct 16 14:09:15 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Oct 16 15:09:52 2020 |
tree | e754277ee76c8a416aa5958797dbbf854ae82965 | |
parent | 965f766c50ff59f0742d86d263c6ea0245adf52b [diff] |
[:is/:where] Support :link/:visited For :link/:visited, the current behavior of SelectorChecker is that both pseudo-classes will match any link (element.IsLink() == true), regardless of their visited status. We then rely on the "static" analysis of the selector (ComputeLinkMatchType()) to understand apply-time whether to apply normal properties, -internal-visited properties, or both. Hence, we are in a way delaying the "real" match/no-match decision to apply-time. This becomes complicated when :not() is involved, because we can no longer simply invert the result of CheckOne: :link will match *any* link, including visited links, so :not(:link) would (naively implemented) *not* match visited links (which is should: it should match anything *except* an unvisited link). There's an attempted mitigation in place in CheckPseudoNot, where we check differently for :link/:visited, but it doesn't work properly. There are still cases where we don't match what we should (see the updated test not-links.html). When :is()/:where() is added to the mix, it becomes even more complicated, as :not() can effectively nest, for example :not(:is(:not(:visited))). To deal with this complexity, this CL proposes an alternative handling of visited links, in which we sometimes perform selector matching twice. If we are inside a visited link, we first match the selector as if we are *not* inside a visited link, and record the result, and then match again with the real link status, and record that result as well. This makes nested :not() scenarios work automatically, because CheckPseudoClass is now actually checking the link status, rather than just matching any link. Obviously matching the same selector twice has performance implications. To mitigate this as much as possible, we avoid the double matching behavior for selectors which don't contain :visited or :link (even if we're inside a visited link). Bug: 568705 Change-Id: I08eeb225d52418b80535f996cecc888b05e23eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476214 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#817900}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!