| commit | 75aeef19a407d18832cf0c3946781f97266f74a2 | [log] [tgz] |
|---|---|---|
| author | Ian Kilpatrick <ikilpatrick@chromium.org> | Tue Oct 27 03:14:17 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Oct 27 04:46:07 2020 |
| tree | 0602d3daf5aef18bc9a2fae392123f7f92d8c078 | |
| parent | 29d183c853ecfcbd6aaf75063ca5eddfedb6096f [diff] |
[GridNG] Implement alignment within grid-areas. This patch implements alignment within a grid-item's grid-area. When creating the GridItemData we read of the containers, and grid-item's style, or determine its alignment axis-edge, and if it should be stretched, saving this information on the GridItemData. When placing the grid-item it will use this to adjust the offset. This doesn't implement baseline alignment which requires a secondary pass to correctly determine the baseline for the column/row. The other TODO relates to the constraint-space API, and how grid will need a slightly new concept in order to do block-axis stretching easily. By default non-replaced grid-items will stretch to the available space. A new bit on the space can indicate that we should stretch to the available space (if possible), this is similar to the shrink-to-fit bit we have today. This adds a self-start/self-end test as after implementing this now new tests passed immediately, and I don't believe we had good test coverage for inflow content with these keywords. Bug: 1045599 Change-Id: I8c9cc51381c3d75519e52b32472b58ec96a6a85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492176 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#821043}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!