commit | af2796bc4ea941309f2f1f55c05e81b1dcef7ffb | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Fri Oct 30 23:31:27 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Oct 31 00:08:14 2020 |
tree | bec28b08e41879f0968a3013047f06f5051ef38c | |
parent | 1e74a19727a248b10c61b4218e1e6875c7c44a33 [diff] |
[LayoutNG] Use offsets relative to the block flow when using legacy APIs. We still use the legacy layout engine APIs when calculating offsets relative to some ancestor (needed by DOM APIs such as offsetLeft, offsetTop and getClientRects()). This means that we cannot use offsets relative to the containing box fragment. We need to make them relative to the containing LayoutBlockFlow instead, or machineries such as LayoutObject::MapLocalToAncestor() will fail when in block fragmentation. Also fixed an issue in the NG-to-legacy-writeback code. It was wrong for RTL, since we used the inline-size of the column (rather than that oof the column set) when converting between logical and physical offsets. This alone doesn't fix any existing tests, but it is needed by the new tests added in this CL, and also helps fix a couple of the existing tests that now pass. Also move one ContainingBlockFlowFragmentOf() call out of the way (we get nullptr when block-fragmented). Moved it into paint fragment-specific code, which was the only code that needed it. Bug: 829028 Change-Id: Ib19b11ecfdd47cdd77aed41c6935be86004fe166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508590 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#822860}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!