| commit | ccb29a2eaf3a7ff05e2cb47e76cf1cfcb59ebc0c | [log] [tgz] |
|---|---|---|
| author | Anders Hartvoll Ruud <andruud@chromium.org> | Fri Nov 20 12:41:53 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Nov 20 13:00:46 2020 |
| tree | 97be4908b5374dabeaaa6ee62d613b84f611f5f2 | |
| parent | 16d2dd4febb588e7174d0637f1211b040cd0bbab [diff] |
[scroll-animations] Run style/layout twice if necessary This CL solves the "first frame problem" [1], where ScrollTimelines created by style recalc end up as inactive, because layout hasn't run yet at the time that style recalc takes place. When a new timeline is created, it goes into a list of "unvalidated" timelines. During the lifecycle update, right after the style and layout steps, we go through all such timelines and check if the current timeline state (snapshot) is "stale" compared to a freshly computed snapshot. If it is, it means that layout had some effect on the timeline(s) that we would like to include in the next frame. We then mark the associated effect targets for style recalc, which in turn triggers a re-run of the style/layout steps in the lifecycle. After all timelines have been validated, the list of unvalidated timelines is cleared. This guarantees that we don't accidentally trigger style/layout more than twice. [1] https://github.com/w3c/csswg-drafts/issues/5261 Fixed: 1145933 Bug: 1074052 Change-Id: Ic915bb71b204c93cbde1c5f485d26a4b1c2bd09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517448 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#829624}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!