commit | 6db65e7a68bdb745a37d0e2a012920551e5e86ef | [log] [tgz] |
---|---|---|
author | Ben Kelly <wanderview@chromium.org> | Wed Dec 09 00:50:40 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Dec 09 01:11:39 2020 |
tree | 14d93558a9d137ff859c5f6a2fa8d1c5a49b0080 | |
parent | 8685e224bb74c677bfff978faf131b0d567370e8 [diff] |
URLPattern: Implement exec(). This CL provides an initial implementation of the URLPattern.exec() method. It mainly differs from test() in that it returns a full URLPatternResult object instead of just a boolean. The result object looks something like: { input: <input string or object passed to exec()>, protocol: <component result>, username: <component result>, password: <component result>, hostname: <component result>, port: <component result>, pathname: <component result>, search: <component result>, hash: <component result> } Each URLPatternComponentResult looks like: { input: <input component string>, groups: { <group name or numeric number string>: <matched group value> } } To support extracting matched group values this CL enhances ScriptRegexp to populate an optional vector of strings. In addition, this CL enhances the WPT tests to process expected result objects. In general it is only necessary to provide component results for components that match non-empty inputs. The test runner will automatically add expected results for empty components. This CL also contains a fix in ApplyInit()'s handling of baseURL. The intent was to treat non-specified components as the explicit empty string. The code now does this. This also happens to handle the unexpected behavior of KURL::GetPass() which always returns a null string in place of an empty string. Finally, this CL removes the toRegex() stub as well. That API is unlikely to land in the current form, so lets just remove it until it can be properly designed. Bug: 1141510 Change-Id: Iedd0598a3d5e493c3e7ed0eb5dce4b09019abca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575343 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#834967}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!