| commit | 65e68547032c551e8765245621a9aac70e5d5a3d | [log] [tgz] |
|---|---|---|
| author | Mason Freed <masonfreed@chromium.org> | Thu Dec 24 00:58:24 2020 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Dec 24 01:19:20 2020 |
| tree | bd23e327d7b59a9f29dc807cb79a058bfb87c195 | |
| parent | ec1a688d4d3f196e43236d68ba69c4dc709d167b [diff] |
Fix serialization for <noscript> contents when script is disabled Previous to this CL, serialization for <noscript> nodes in a document with (per spec) no execution context would still *not* escape (e.g. '<' --> '<') the contents. This allowed a sanitizer bypass. I added a fairly comprehensive test of the many fragment parser entry points here. Before this CL (and on other browsers): - Chrome would never escape <noscript> contents. (This bug) - Firefox would never escape <noscript> contents. (Should raise a bug) - Safari *always* escapes <noscript> contents, *even* when it shouldn't, such as with div.innerHTML, div.insertAdjacentHTML, and document.write on the main document. (Should raise a bug) An additional set of differences showed up for the *parsing* escaping behavior: - Chrome would (and still does) de-escape <noscript> contents when parsing in a script-disabled context, such as DOMParser or createHTMLDocument.innerHTML. It does *not* de-escape <noscript> contents in script-enabled contexts, such as div.innerHTML and document.write. This all seems correct to me. - Safari behaves identically to Chrome here (correct). - Firefox de-escapes <noscript> contents in some cases (e.g. XMLHTTPRequest, document.write) but not others (e.g. template.innerHTML, createHTMLDocument.innerHTML, and createHTMLDocument.createContextualFragment). I looked for a spec issue, but didn't find one. If there really isn't a spec issue for this, we should raise one. Fixed: 1160635 Change-Id: I361a72409093e69b074495c475e9d647c6c58300 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602447 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#839214}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!