commit | 3afc7b5bf678afb3ae26517ea6f31f73cb385147 | [log] [tgz] |
---|---|---|
author | Stephen Chenney <schenney@chromium.org> | Fri Mar 19 19:08:55 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Mar 19 20:00:16 2021 |
tree | 5534d4ddbeda2a4814de53ee4db46e94d64c8c80 | |
parent | c36fafed84c9dd16cfa38f66a84ccca5cf32b3e4 [diff] |
Enable Paint Holding Cross Origin for tests The Paint Holding Cross Origin feature extends Paint Holding to most navigations. Paint Holding defers the first commit of rendering data from the main thread to the compositor until after First Contentful Paint, or a 500ms timeout, has occurred. From a test perspective, the most important change is related to input. We drop all input when not updating the document lifecycle and while deferring the commits. Many tests expect to navigate and then immediately process input, and these tests timeout or otherwise fail with Paint Holding. Three strategies have been employed to address this: - For many tests it is sufficient to add text to the html content so that First Contentful Paint is reached upon load and commits begin. This works well for most cases but unfortunately the linux_chromeos_rel bot is still flaky, probably due to slower loading. - Some tests just need to wait for hit test data, using WaitForHitTestData - In other cases we allow early input using the blink flag. Test coverage for Paint Holding is provided by essentially all tests that use input or require a rendered result, so there is little concern about using the early input flag in a few test suites. This change may cause increased flakiness, particularly on the linux-chromeos-rel bot and Android. Please assign flakiness bugs to schenney@ and ping if necessary. Bug: 1120158 Change-Id: Ief45735c5bdb4d48d6554dcfc12e3b621355e080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368282 Reviewed-by: Clemens Arbesser <arbesser@google.com> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#864725}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!