commit | 961fa62212aee35356caf3ecbf8e486118aae080 | [log] [tgz] |
---|---|---|
author | Alison Maher <almaher@microsoft.com> | Mon Mar 15 20:38:43 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Mar 15 20:58:00 2021 |
tree | 7c8ad130c72bd53a64e2c0ed36da57756ac6c63a | |
parent | b74014abe0da655dd4675b1ddce4364eabc0b3de [diff] |
[LayoutNG] Nested abspos/fixedpos in multicol Nested abspos elements in a multicol whose outer abspos started in a new column was broken. The reason being that the inner abspos was added as a descendant twice. Once when PropagateOOFPositionedInfo() was called during OOF layout, and a second time when the new column was added as a child to the multicol builder via AddChild(). To fix this, add a bool to AddChild() and AddResult() to determine whether or not we should propagate up OOF descendants. This prevents us from adding such inner abspos elements as descendants twice, as well as avoiding repeated OOF descendants when building up the multicol builder in a nested fragmentation context. As a part of this change, I also moved the propagation of non-fragmentainer OOF descendants into PropagateOOFPositionedInfo() since we can skip such work in the above cases, as well. Previous to this change, nested fixedpos elements inside a multicol weren't getting laid out. This fixes the problem for simple multicol scenarios. However, this does not fix the problem for nested fragmentation contexts or for cases where the containing block of the fixedpos is somewhere inside the multicol. Thus, nested fixedpos handling will likely need to be handled in a different way. However, I've added a simple wpt test for a nested fixedpos to illustrate what behavior is currently working. Bug: 1079031 Change-Id: I6fd5af2249a374676158f491717f8cc03b447e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2754727 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#862929}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!