commit | f08be1e3546abcc9d0883a32eec782a8ba0bb562 | [log] [tgz] |
---|---|---|
author | Ben Kelly <wanderview@chromium.org> | Tue Mar 16 15:57:20 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Mar 16 16:16:22 2021 |
tree | 288c9e840b03f7e95e067843a51b5e08d13b7941 | |
parent | a4db9cbd7e9da1509078d29fde7496d35bb8d6ab [diff] |
URLPattern: Add per-component pattern getters. This CL exposes the parsed, canonical pattern as a property on the URLPattern object. This canonical pattern string is generated from the liburlpattern::Pattern object. The CL also expands on the WPT test to verify pattern string properties are exposed properly. The test driver does most of the work and the data file only needs to provide overrides where the canonicalization has made the expected pattern non-obvious. Finally, this CL also drops the TODO to add a stringifier. As discussed in the following issue we have decided not to add a stringifier for now: https://github.com/WICG/urlpattern/issues/47 Developers may try to use a stringifier as a serialization mechanism which is something we want to avoid. The URLPattern properties, however, are exposed and human readable in devtools. Bug: 1141510 Change-Id: Ifeacd06d5885158777b290f8eb54ed2175be7201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729489 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#863284}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!