commit | 0472520c177db9c478fe9062fad2f7344b6bb864 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Mon Mar 22 22:42:28 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Mar 22 23:02:25 2021 |
tree | ebf601c13f9dcaa01e76b4b78779e1d08ba6b740 | |
parent | 831cc6b66f7d65d645606b6ed1855e39d4bd0ef8 [diff] |
Propagate the appeal of early breakpoints correctly. When an early breakpoint was "deeply" nested (deeper than 1 level or so) compared to the unappealing breakpoint further down where we actually ran out of space, we'd lose its break appeal, because break appeal is recorded in MovePastBreakpoint(), which we'd miss in the second layout pass (initiated by RelayoutAndBreakEarlier() in NGBlockLayoutAlgorithm), because we'd return early if there was an early break. It should be harmless to just run through the entire machinery even if we are / were looking for an early break. So: Remove code. Fix bugs. In the test included we'd run out of space before #c, then abort and relayout the column to the ideal breakpoint that we found before #b. But we'd also break before #wrapper1 unnecessarily because of this bug, and then break again before #b. All we need is a break before #b. This content only requires 2 columns, not 3, but when considering a break before #wrapper1 in the second (early-break) layout pass, the appeal of breaking inside it would be kBreakAppealLastResort rather than kBreakAppealPerfect. So we'd incorrectly decide to break before instead of keeping the nice break we had found (deeply) inside it. Bug: 829028 Change-Id: I7b17d5b7045be3cdb3038e0a581471ac3ea1b070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2778315 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#865387}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!