| commit | 0d7dd845ec0c0482cbd8c11bddafe9878dc32522 | [log] [tgz] |
|---|---|---|
| author | Ben Kelly <wanderview@chromium.org> | Tue Mar 23 21:20:35 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Mar 25 11:53:19 2021 |
| tree | 977b9cd64e6d08127467a1ac199a87e72ff4ff15 | |
| parent | c89882cb8571e454e0643c3584206a48f9b37049 [diff] |
URLPattern: Allow a second argument to test()/exec() for baseURL.
This CL adds support for code to pass a secondary argument to test()
and exec() to act as a baseURL. For example:
pattern.test('./index.html', self.location);
To support this the webidl was restructured to have separate method
overloads for USVString and URLPatternInit inputs. In addition, the
internal implementation was refactored to account for the fact that
a union type is no longer used for the input.
Finally, there was one open question about what to reflect in the
`input` property on the URLPatternResult returned from exec(). This
property contains the input passed to exec(). In the past this was
always a single value, but now there are two values. This CL deals
with the situation by populating `result.input` with the fully resolved
URL when a baseURL is present. This is a bit inconsistent with the
value when populated in other cases, but seems less weird than trying
to use an array or secondary property.
Bug: 1141510
Change-Id: Ia247f59b1541ca254ba7d1d871f64d65a7b0b7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2779364
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#865794}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!