| commit | f68f2e6bbe1c50a30e690243b64906f2a490e515 | [log] [tgz] |
|---|---|---|
| author | Felipe Erias <felipeerias@igalia.com> | Wed Apr 14 18:02:32 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Apr 14 18:26:12 2021 |
| tree | ddc3d01126e9f961886084205af78c522b7a22dc | |
| parent | b3804b4ee1c96551ef3eccb7d4fb578db0ff3d21 [diff] |
Initial implementation of scrollbar-width ComputedStyle::HasCustomScrollbarStyle() returns true if a custom style for the scrollbar has been set via ::-webkit-scrollbar and the value of scrollbar-width has not been changed from the default. This replaces HasPseudoElementStyle(kPseudoIdScrollbar) so the standard properties for styling scrollbars take precedence over the non-standard method. For convenience, the method Scrollbar::CSSScrollbarWidth() returns the value of the scrollbar-width property in that scrollbar's style. Scrollbar themes take scrollbar-width into account when calculating a scrollbar's thickness, margin, etc. When scrollbar-width is "none", scrollbar themes simply return a thickness of 0 to hide the scrollbar. WebThemeEngine::ScrollbarStyle includes the thickness and margin values for the thin variant. ScrollbarThemeMac uses NSRegularControlSize and NSSmallControlSize to size and display the appropriate type of scrollbar for the default and thin variants. ScrollbarThemeOverlay stores the thickness and margin for the thin variant, although at the moment these values are the same as the default (pending changes to WebThemeEngine). The same applies to the ScrollbarThemeOverlayMobile subclass. ScrollbarThemeAura simply scales the default scrollbar by a 2/3 ratio to paint the thin variant. In the future, the theme should include specific width values for this variant. Perhaps it would also be desirable to use a different set of graphic elements. WPT tests are included. Bug: 891944 Change-Id: I2d451f07de5a16e6cada8a68ae01da7358e8652a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2681340 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Felipe Erias <felipeerias@igalia.com> Cr-Commit-Position: refs/heads/master@{#872500}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!