commit 99efbde7f07b6d1b8e6a7708e99c592689451c3d
author Alison Maher <almaher@microsoft.com> Thu Apr 22 18:45:31 2021
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Thu Apr 22 19:05:55 2021
tree 23d88cf424751fce239b89760fac5b5fb4ab113b
parent f0100ca251375fc5bf241d14ceaf6dbef74432e9

[LayoutNG] Nested fixedpos in nested multicol w/ CB in outer multicol

Nested fixedpos elements in a nested multicol were handled previously
by CL:2791850 and CL:2823871. However, if a fixedpos was nested in an
OOF element inside a nested multicol, and the containing block for
the fixedpos was in an outer multicol, the fixedpos was never laid out.
The reason being that when we add an inner multicol with pending OOFs,
we don't make any changes to its OOF descendants. So if the fixedpos
containing block existed outside the inner multicol but inside the
outer multicol, fixedpos_containing_block in NGOutOfFlowPositionedNode
would never be set.

In order to fix this, we need to store a fixedpos_containing_block along
with any inner multicols with pending OOFs, if one exists. A new
struct, NGMulticolWithPendingOOFs, was added to store this information.
The fixedpos_containing_block gets set the first time the inner multicol
reaches a potential fixedpos containing block.

The multicol_offset variable of NGMulticolWithPendingOOFs was added for
two purposes:
  1. Similarly to CL:2836226, the static position was incorrect for
    nested fixedpos elements in a nested fragmentation
    context, and whose containing block was outside both multicols.
    (See fixed-in-nested-multicol-with-transform-container.html for an
    example).
    In this case, multicol_offset is the accumulate multicol offset
    relative to the outer fragmentation context. This gets added
    to the static pos of any fixedpos descendants in
    NGContainerFragmentBuilder::TransferOutOfFlowCandidates().
  2. In the case where the inner multicol found a fixedpos containing
    block, multicol_offset will be the offset from the multicol
    to the top of the fixedpos containing block. This is also used
    in NGContainerFragmentBuilder::TransferOutOfFlowCandidates() to
    ensure that the fixedpos static position is correctly updated.

MulticolCollection was updated from a HeapHashSet of inner multicol
LayoutBoxes to a HeapHashMap from inner multicol LayoutBoxes to
NGMulticolWithPendingOOFs.

In order to avoid creating two NGMulticolWithPendingOOFs structs (one
for the logical space and one for the physical space), the
NGContainingBlock struct was also updated to a templated struct.

Note: this CL does not handle the case of more than two layers
of nesting. For example, in the following case, the fixedpos would
not be laid out at the correct offset:
  multicol
    multicol
      transform
        multicol
          relpos
            abspos
              fixedpos

In order to get this case working, we'd also need to store a reference
to the multicol that the fixedpos containing block was found in inside
NGMulticolWithPendingOOFs. However, this use-case doesn't seem worth
handling at this time.

Bug: 1198674,1200324
Change-Id: I213c35514fecf84fc62e55fe5531cff8b0830429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2844299
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#875257}