| commit | 8a3b76e15ef8a2a9c9ac16563e2f670003f89d3c | [log] [tgz] |
|---|---|---|
| author | Byungwoo Lee <blee@igalia.com> | Thu Jun 03 10:23:36 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Jun 03 10:41:08 2021 |
| tree | 2051f84c26a8ae30b7d509d78a1ff770786ac035 | |
| parent | a767cb459617cdc4bc1010b78c61fd348c3ef1c0 [diff] |
Supports :has() pseudo class matching Add :has() pseudo class syntax support and matching logic behind a runtime test feature (CSSPseudoHas) <Syntax support> Add syntax support for :has() pseudo class specified in Selectors 4. - https://www.w3.org/TR/selectors-4/#relational :has() pseudo class takes a relatvie selector list as an argument. - :has(<relative-selector-list>) - <relative-selector-list> = <relative-selector># - <relative-selector> = <combinator>? <complex-selector> <relative-selector> is also specified in Selector 4, but it is not supported yet. - https://www.w3.org/TR/selectors-4/#relative So this CL only supports :has argument selectors starting with descendant combinator. Argument selectors starting with other combinators are not supported yet. - .a:has(.b) : Supported - .a:has(> .b) : Not supported yet - .a:has(~ .b) : Not supported yet - .a:has(+ .b) : Not supported yet <Selector matching> Add :has() pseudo class selector matching logic. This CL suggests a stack-allocated :has() matching status cache to prevent repetitive tree traversal and argument selector matching operation. The cache stores each element status as below. - Matched : Checked :has() and matched - Checked : Checked :has() but not matched - NotChecked : Not checked :has() (default) This is the pseudo code of the matching operation for the :has pseudo class with descendant relative argument selectors. (e.g. ':has(.a)' or ':has(:scope .a)') ┬ Allocate cache on stack memory ├ Enter the style recalculation(or node selector API) sequence │ ├ ... │ ├ Enter the selector matching sequence │ │ ├ If matching :has pseudo class on an element │ │ │ └ Enter :has selector matching sequence │ │ │ ├ Get argument selector │ │ │ ├ Get element status from cache │ │ │ ├ If the element status is checked │ │ │ │ └ If the element status is matched │ │ │ │ └ Finish has pseudo class matching as matched │ │ │ ├ Else │ │ │ │ ├ Set the element status as checked │ │ │ │ └ Traverse all descendants of the element │ │ │ │ ├ Get the descendant status from cache │ │ │ │ ├ If the descendant status is checked │ │ │ │ │ └ If the descendant status is matched │ │ │ │ │ ├ Set the element status as matched │ │ │ │ │ └ Finish has pseudo class matching as matched │ │ │ │ └ Else │ │ │ │ ├ Set the descendant status as checked │ │ │ │ └ If the descendant matches the argument selector │ │ │ │ ├ Get start element of the shortest match │ │ │ │ ├ Traverse it's ancestors until met the element │ │ │ │ │ └ Set the ancestor status as matched │ │ │ │ ├ Set the element status as matched │ │ │ │ └ Finish has pseudo class matching as matched │ │ │ └ Finish has pseudo class matching as not matched │ │ └ Otherwise │ │ └ Do other selector matching sequence │ └ ... └ Release cache from stack memory Other cases will be handled later in the separated CLs. - :has(> .a) or :has(:scope > .a) - :has(~ .a) or :has(:scope ~ .a) - :has(+ .a) or :has(:scope + .a) This CL supports :has with the following javascript APIs. - querySelector - querySelectorAll - matches - closest Changes in this CL were originally in the below 2 CLs. Those are merged to prevent a web_test failure. (jquery/traversing.html) - https://chromium-review.googlesource.com/c/chromium/src/+/2648150 - https://chromium-review.googlesource.com/c/chromium/src/+/2695192 Change-Id: I1992b70d86f47fc5f98437e1e6abea2da021ef6b Bug: 669058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2914717 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Byungwoo Lee <blee@igalia.com> Cr-Commit-Position: refs/heads/master@{#888799}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!