commit | 3b1c1631085e7af5f48d0e38c6a84410c2a9e96c | [log] [tgz] |
---|---|---|
author | Nate Chapin <japhet@chromium.org> | Fri Jun 25 18:43:02 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Jun 25 18:53:54 2021 |
tree | 78af3ad7099c6acac3f2b38e7ff619ed4adb1810 | |
parent | 90c83d9317172d8ccb5a03e852ad78669db37a19 [diff] |
Allow navigating parent and child during history traversal This is a behavior we've wanted for years, but which could cause serious breakage in the absence of FrameNavigationEntries being shared across multiple NavigationEntries. That was implemented in https://chromium-review.googlesource.com/c/chromium/src/+/2910529 Normally, when sharing FrameNavigationEntries, we "fork" the entry when it is updated due to navigating cross-document (unless reloading the same url). However, this does not work well when navigating away from an initial empty document, because we want to hide any empty documents at the start of an iframe's lifetime. In particular, in the case where an iframe and the main frame racily navigate, we can end up with an initial empty document's FNE shared across 2 different NavigationEntries. It is important that when the first real navigation takes place, we update the existing entry rather than fork, so that the initial empty document is overwritten in both places. Therefore, add a special case in NavigationControllerImpl::RendererDidNavigateAutoSubrame, to ensure an initial empty document is always updated rather than replaced. Bug: 542299, 598043 Change-Id: I4113cbbcb8dd5d5065e88ad8f5761acc09847543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2953549 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#896133}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!