| commit | 08fb76ca66cf4ee990ed571e7c905deb564f449a | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Mon Jun 28 20:19:11 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Jun 28 20:30:25 2021 |
| tree | 8b8858907e0391573f2ccf4b40e05be2964c34ea | |
| parent | 238ad6636ddfdcd3de3cdb52e4ad3dffbd1f91a0 [diff] |
Append nested fragmentainers for OOFs if needed. In a nested fragmentation context (e.g. multicol in multicol), if an OOF couldn't fit in the fragmentainers than we already had, we'd just put multiple fragments for the same OOF into the last fragmentainer, with an additional inline-offset for each fragment. With an upcoming pre-paint change, this approach is problematic, since we want to use the fragmentainer index as a unique identifier for each FragmentData entry. This CL fixes that. We'll now create as many inner fragmentainers that we need, and never put more than one fragment for the same node into the same fragmentainer. This requires us to regenerate inner multicol container fragments, and overwrite references to the old fragments. One consequence of fixing this is that we now also get column rules right in such cases, since column rule painting is based on having the actual fragmentainers there. Bug: 1043787, 1079031 Change-Id: Ie94440a199636f5e29f3443d0ae37a8d079c3759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2988124 Reviewed-by: Alison Maher <almaher@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#896616}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!