| commit | af90106e46aadf95cbab0f2a545f4255338ba22c | [log] [tgz] |
|---|---|---|
| author | Frédéric Wang <fwang@igalia.com> | Mon Aug 02 09:56:41 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Aug 02 10:07:17 2021 |
| tree | db796ad1901bdf46ecb094a99f6c92943f2c461c | |
| parent | da870791bc7edbf03720f23e95f05c0fae380a14 [diff] |
Implement horizontal stretchy operators This is the fourth patch of a series of CL to implement MathML stretchy operators. It only implements basic support for stretching operators along the inline axis (e.g. horizontal arrows). This corresponds to the following text in the spec with a few adjustments: 1. "If the stretch axis of the operator is inline then " from [1], but step 2. is modified to stretch with a zero size in order to get the base size. Additionally, due to current limitations in LayoutNG, one cannot implement "The inline size of the content [is] given by algorithm to shape a stretchy glyph to inline dimension Tinline.". Instead, the base size calculated in step 2 is used during layout. This means horizontal stretchy operators would overflow their bounding box towards the end. To work around that and obtain acceptable rendering, the paint offset is adjusted to make the overflow symmetric on the start/end sides. This also splits the excessive gap symmetrically for vertical operators, see [2]. 2. Inserting [3] in the algorithm of the munder/mover/munderover layout [4][5][6]. However, embellished operators [7] are not implemented yet. Instead, they are just treated to be equivalent to an <mo> element. Additionally, step 1. is skipped for now since it only makes sense when the element using the munder/mover/munderover layout is itself an embellished operator. Because the inline sizes of horizontal stretchy operators do not match those of the painted glyph, this CL only adds a basic reftest to check visual rendering of stretchy operators. More exhaustive, more easily readable and less fragile testing could be done in the future when one can just rely on measuring boxes with getBoundingClientRect(). [1] https://w3c.github.io/mathml-core/#layout-of-operators [2] https://chromium-review.googlesource.com/c/chromium/src/+/3013775 [3] https://w3c.github.io/mathml-core/#algorithm-for-stretching-operators-along-the-inline-axis [4] https://w3c.github.io/mathml-core/#base-with-underscript [5] https://w3c.github.io/mathml-core/#base-with-overscript [6] https://w3c.github.io/mathml-core/#base-with-underscript-and-overscript [7] https://w3c.github.io/mathml-core/#dfn-embellished-operator Bug: 1124301, 6606 Change-Id: I13bd5e2753c062b4f54ed67f0a86f468c4ac0e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3006734 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#907482}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!