| commit | 1bce3fabaaf18dda576d83f64f3ef03bdd647e3b | [log] [tgz] |
|---|---|---|
| author | Alison Maher <almaher@microsoft.com> | Wed Aug 11 16:19:33 2021 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Aug 11 16:31:33 2021 |
| tree | 5f2bcb3a87e43ff4f6c1e97375b313f64a4a071f | |
| parent | 2af6337ba28f44880558f1a637725d4673e7065f [diff] |
[LayoutNG] Break token for new column before spanner In CL:3018723, logic was added to the column layout algorithm to lay out any OOF descendants when we find a spanner to ensure that any OOF descendants found before a spanner are actually laid out before the spanner. If a new column was created for an OOF before the spanner, we wouldn't end up creating a column break token for that new column if the OOF didn't break. This CL adds logic to NGSimplifiedOOFLayoutAlgorithm to make sure that a break token is created for the column in this case. Additionally, if any columns are added after the spanner, we would end up crashing because the new column created for the OOF was not taken into account when adding the subsequent column (i.e. the sequence number and consumed block size were incorrect, and the subsequent column was added to the flow thread at the wrong index). To fix this, update the next column break token in MulticolPartWalker to the break token of new column added for the OOF. In order for layout to continue correctly from this new break token, any child break tokens from the previous column needed to be copied over to the new column generated during OOF layout. Otherwise, those children would not resume layout after the spanner. In addition, if an existing column fragment was replaced via NGSimplifiedOOFLayoutAlgorithm, and it had a child that had broken due to a break before, we would miss adding that child break token via child_iterator_. To fix this, add any child break tokens from the old fragment that were the result of a break before prior to simplified layout completion. Bug: 1237247 Change-Id: I55c73fc36a604e858dde5859f65a1ca66023e54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3082315 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#910828}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!