commit | c8171509da43d6ab5db52c3dd41b0c641a3a8a4a | [log] [tgz] |
---|---|---|
author | Frédéric Wang <fwang@igalia.com> | Thu Aug 26 17:52:29 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Aug 26 18:10:48 2021 |
tree | b9ee2586a7687b64934c62a8fb3ef72b0a1f00c1 | |
parent | daaa86b4f16858cfb72288c26dd90a5576290cd5 [diff] |
Stack-overflow in blink::IsSpaceLike The IsSpaceLike and GetCoreOperator functions receive a NGBlockNode node parameter. When it corresponds to a grouping element or an <mpadded> element in the DOM tree, then these functions browse its children, casting each one to a NGBlockNode. This works for the grouping/<mpadded> elements with math display (since they blockify their children) but may hit "Security DCHECK failed: IsA<Derived>(from)" for other display values. To address that issue, an early exit is added in IsSpaceLike similar to the one that already exists in GetCoreOperator. See [1] for the related specification discussion. [1] https://github.com/w3c/mathml-core/issues/108 Bug: 1243691, 6606, 1124298 Change-Id: I4ddd4d57b20ffce0e6ef6fd2cf478b8c77363440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3122134 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/main@{#915635}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!