commit | 57c7282839049b334bd96aa6cc7e336b2dfae558 | [log] [tgz] |
---|---|---|
author | Dominic Farolino <dom@chromium.org> | Wed Sep 01 00:46:45 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Sep 01 00:58:44 2021 |
tree | 5795918e8ed127dcca98f36e3081ab449428addb | |
parent | c472b505c61ab279a3d28079fa0a5c40fe3ba600 [diff] |
Lazyload: Lazyload images can load from the list of available images As per step 6 in #updating-the-image-data [1], all images including lazyloaded ones are able to load immediately from the list of available images. This CL adds a test ensuring this is the case, specifically for out-of-viewport `loading=lazy` images. If it is determined in https://github.com/whatwg/html/issues/7005 that even in-flight requests are able to be placed in the list of available images, this would increase the utility of the list of available images, and maximize the number of requests that can "coalesce" with entries in said list. In that case, we'll need to: 1.) Correct the tentative expectations introduced in crrev.com/c/3133524 2.) Write a test specifically for lazyload to verify that lazyloaded images don't have special behavior, and can indeed coalesce with in-flight requests in the list of available images [1]: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:list-of-available-images R=domenic@chromium.org Bug: 994329 Change-Id: I511c09073226f729782c47cc135d36efd2ef4723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3133207 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#917059}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!