commit | 3d56f2cc3e241a413c6801597a5895eeb9c1dded | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Thu Sep 09 16:23:44 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Sep 09 16:51:15 2021 |
tree | a128f03a02be97dc9fecec52e3f151e5239ff703 | |
parent | 8097f1959cf300cd423192fe36d00c05c58c066c [diff] |
Improve breaking before nested multicols and their rows. 1. Avoid breaking inside an inner multicol fragment if there were suboptimal breaks inside even if the inner multicol container didn't break in the outer fragmentation context. multicol-nested-018.html, multicol-nested-022.html and multicol-nested-023.html test this. 2. Properly constrain balanced column block-size to remaining space in the outer fragmentainer. We used to let unbreakable content override the remaining space, but this is wrong. This fixes forced-break-too-short-column.html and nested-short-first-row-extra-tall-line.html Store break appeal in NGLayoutResult, rather than in NGBreakToken. The reason is that we may have a violating break inside a fragment that happened inside a nested fragmentation context, even if the fragment doesn't necessarily break within the outer fragmentation context. Also create a proper break token inside a nested multicol container if there is none and we want to break before the first piece of column content. Calling SetDidBreakSelf() manually, like we used to, confused FinishFragmentation() into thinking that we were past the end of the block-end content box of the multicol container. This is tested by nested-with-padding.html Because of this change, the code in PreviousInnerFragmentainerIndex() needed an update, to ignore this break token, since break-before tokens don't have a sequence number. Remove the has_violating_descendant_break flag, and use the break appeal in the layout result instead. We had a column-balancing bug where where we were missing break-inside:avoid violations, because such violations don't affect the child's stored break appeal (the reason for this is explained in further detail inside CalculateBreakAppealInside()). Such violations were already propagated correctly to the builder's break appeal, so now it just works. This is tested by multicol-fill-balance-014.html . Also remove LayoutNGBlockFragmentation-specific baselines for moz-multicol3-column-balancing-break-inside-avoid-1.html because of this, as we now render identically to the legacy engine. This change fixes some existing tests. It also made outer-column-break-after-inner-spanner-2.html render correctly, but not according to the expectation, which was written for the legacy engine. The legacy engine fails to push the block with the BR inside entirely to the next outer fragmentainer. So replce it with a correct test: multicol-nested-017.html Bug: 829028 Change-Id: I13b2d95a0eb0407a82c8c24070a6dff4d2f620e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3150413 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#919825}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!