commit | cfd3cb72b2e9cb5167d42367c16c9a7d580b3d2d | [log] [tgz] |
---|---|---|
author | Nate Chapin <japhet@chromium.org> | Sat Dec 11 04:15:14 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Dec 11 04:29:41 2021 |
tree | 3f127895f164c36a9ae3d16b05ce2e75fb815c3e | |
parent | 971551c7724a00ead670d30ed4d05e7f6f0c3d33 [diff] |
appHistory transitionWhile() custom start/stop notifications The appHistory prototype introduces a way for web developers to intercept a navigation and cause it to be treated as an *async* same-document navigation. AppHistoryNavigateEvent has a function called transitionWhile() that takes a promise and considers the navigation complete when the promise is resolved. In order to have a transitionWhile()-intercepted navigation be a full fledged navigation, the browser UI should show a navigation in process until the promise is resolved. This requires: 1. Making same-documents generally use the same start/stop navigation tracking as cross-document navigations in blink. 2. Special-casing transitionWhile() to not immediately complete like other same-document navigations, and instead completing when the promise resolves. 3. Adding logic to FrameLoader::DidFinishNavigation() to ensure that it does not erroneously complete while AppHistory thinks a navigation is still in progress. 4. Browser-side special-casing to ensure that the browser UI shows the navigation-in-progress UI elements for transitionWhile(). Currently, it only does this for cross-document navigations. Bug: 1241202 Change-Id: I3fccebded69a74c9c8679501755acb531fa05841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3049791 Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#950735}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!