| commit | d6e2a741f5f85c0a91d9a8e9fe6066986d5f3ce4 | [log] [tgz] |
|---|---|---|
| author | Emilio Cobos Álvarez <emilio@crisal.io> | Fri Oct 01 11:22:49 2021 |
| committer | moz-wptsync-bot <wptsync@mozilla.com> | Fri Oct 01 12:11:12 2021 |
| tree | 61a3a658b1a10668097a57f00123540164df332b | |
| parent | cd72c1fe8c1eed293a344288874e2a07383a6154 [diff] |
Fix reflow root handling in presence of inherited changes in FrameNeedsReflow. The issue here is that we don't clear the cached intrinsic size of the flex item, but this reproduces without flex at all. The main issue is that we choose whether to clear the intrinsic sizes from a reflow root (the outer svg in this case) based on whether the reflow changes size or position: https://searchfox.org/mozilla-central/rev/3fa5cc437a4937c621ea068ba5dc246f75831633/layout/base/RestyleManager.cpp#1224-1229 This is ~fine, except the nsChangeHint_ReflowChangesSizeOfPosition hint can be "inherited" (and thus be cleared if already subsumed by a parent): https://searchfox.org/mozilla-central/rev/3fa5cc437a4937c621ea068ba5dc246f75831633/layout/base/nsChangeHint.h#465-469 This is ~fine, as we'll already start the reflow further up the tree (so we don't need to start go past the reflow root), but we still need to clear the ancestor intrinsics. We still get to StyleChangeReflow with the ClearAncestorIntrinsics hint. We could pass that information down, but the information is really already in via the IntrinsicChange. I think it's just not correct to stop clearing intrinsic sizes if the target is a reflow root and we get a TreeChange/StyleChange, regardless of whether it changes size/position. It should also be a few less instructions, though not that it matters. Depends on D126812 Differential Revision: https://phabricator.services.mozilla.com/D126813 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1730351 gecko-commit: edb7b0ca847baac1ebc8c79f056c4ee08d0a480f gecko-reviewers: layout-reviewers, jfkthame
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!