commit | 0457111e7109ec3d9e575aa421b96d8c36ce2ae8 | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Fri Nov 12 20:41:56 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Nov 12 20:56:13 2021 |
tree | d303704c85a5f25299f22d1c5955eb1e4b4ae7e9 | |
parent | 26bb6529ea8b19b93a1f878ebba79353f87d4da0 [diff] |
[inert] Let modal dialogs make the root element inert From https://html.spec.whatwg.org/multipage/interaction.html#inert, > A Document document is blocked by a modal dialog subject if subject is > the topmost dialog element in document's top layer. While document is > so blocked, every node that is connected to document, with the > exception of the subject element and its shadow-including descendants, > must be marked inert. This doesn't exclude the root element, so it should also be inert. Simply doing this change would break these tests: - html/dialog/modal-dialog-ancestor-is-inert.html - html/dialog/modal-dialog-blocks-mouse-events.html Excluding the root element in HitTestResult::SetInnerNode avoids that. Note I plan to track inertness in ComputedStyle, and then remove both Node::IsInert and hit test retargeting for inert. So this patch is just temporary, to align with the final behavior. Also note that only the the root element (documentElement) is affected. The root node (document), represented as rootWebArea in a11y, will still not become inert when there is a modal dialog or fullscreen element. Bug: 692360 TEST=All/DumpAccessibilityTreeTest.AccessibilityModalDialogOpened/blink TEST=All/DumpAccessibilityTreeTest.AccessibilityModalDialogStack/blink TEST=All/DumpAccessibilityTreeTest.AccessibilityOpenModal/blink TEST=external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unfocusable.html Change-Id: I8ce7905a85e386fae6163423f5e078b6c4588db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3263132 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#941302}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!