| commit | 715d70ea1f8a3db87004793976589a463dcd3631 | [log] [tgz] |
|---|---|---|
| author | Javier Fernández García-Boente <jfernandez@igalia.com> | Tue Jan 18 07:27:02 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Jan 18 07:35:05 2022 |
| tree | 279a6b06134c3d53a6168375c134c4477d031bf0 | |
| parent | ea1821d4bd24ed1e859db03571cca8e783dbf957 [diff] |
Reland "The line offset must include the trailing spaces hang_width" This is a reland of 327959fa6b34cce33d6ad95820132cbfa7d45c81 but with some modifications to avoid regression like bug #1286299. Basically, I don't adjust the line offset if the hang width causes overflow. In r876293 we solved how we computed trailing spaces' width in text using RTL direction. It's worth mentioning that we could implement this change thanks to the first steps toward a full UAX#9 L1 implementation that we started in https://crrev.com/c/2505486. On the other hand, in the NGInlineLayoutAlgorithm::CreateLine function we call to NGInlineLayoutStateStack::ComputeInlinePositions to compute the line_box's inline_size and left offset of the text. For some reason, I believe to make easier the implementation of some alignment and justification related logc, we were ignoring the trailing space hang_width for the box's inline_size, hence its offset in the line. However, in order to correctly place the Caret after a space insertion it's needed to consider this hang_width, which is now properly computed thanks to the change in r876293, as mentioned previously. The bug described in the issue 1278559 is caused by this difference between the caret position computed after the InsertTextCommand, which as I said includes the new hang_width value as a result of the new inserted space, and the current line_box left offset in a RTL text. We are applying some adjustments in the ComputeLocalCaretRectAtTextOffset function, to ensure that the caret_location offset was between the line_box.X() and the right_limit. Since the line_box.X() didn't include the hang_width, the effect was that the caret never advanced to the new position after the inserted space. Bug: 1278559 Change-Id: I2873a80ea74174caf47c3af33c031c4da617cd55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3387789 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/main@{#960270}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!