| commit | 989b944a5cabc049ae004af761e7ebb29d681647 | [log] [tgz] |
|---|---|---|
| author | Morten Stenshorne <mstensho@chromium.org> | Wed Feb 02 20:52:29 2022 |
| committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Feb 02 21:06:59 2022 |
| tree | 645e31d4bf7ddc9add25291e2e47a7697bf145f5 | |
| parent | 0598a5629ea4f8d408e6df0fdca7eab23cc1fbf0 [diff] |
Notify the flow thread about descendant removal in time. With LayoutNGBlockInInline enabled, it's possible to have a spanner block inside an inline. The flow thread keeps track of all the spanners, and the column rows between them, by inserting anonymous spanner placeholder and column set objects. When modifying the tree, the flow thread may need to add or remove spanner placeholders, and merge and split column sets. When removing elements from the tree, it was possible for such two spanners to swap order (because two anonymous blocks were merged into one), without the flow thread noticing, and the spanner placeholder / column set structure wasn't updated. And we'd crash. Therefore, update the flow thread a bit earlier, before LayoutBlockFlow::RemoveChild() gets to have too much fun with the tree structure. Bug: 1292004 Change-Id: Ic4d76d2851fbc1bd9d2dbacc9f350dc21f24a11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3432406 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#966368}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!