commit | cf5a0748e2733a758cf59ea01d655fb1a41d778e | [log] [tgz] |
---|---|---|
author | Alison Maher <almaher@microsoft.com> | Thu Feb 10 03:55:26 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Feb 10 04:09:45 2022 |
tree | 5a05f5bae96667990f949870860a1c7a7cc8fa89 | |
parent | e9d077eb04e5e7b38f638ba89e9dfa745dc11f36 [diff] |
Reland "[LayoutNG] Add PropagateChildBreakValues flag to the ConstraintSpace" This is a reland of 9ef53870dd7989885aceb015576bb7e7eb086422 The original change was reverted due to propagate_child_break_values being uninitialized. To fix this, add an initialization to the RareData ctr. Original change's description: > [LayoutNG] Add PropagateChildBreakValues flag to the ConstraintSpace > > This CL adds a new flag to the ConstraintSpace to propagate child break > values (initial-break-before and previous-break-after). > > The flag is currently set when setting up the constraint space for > fragmentation. However, it will also be used in future changes outside > of the normal fragmentation pass to determine the initial-break-before > and final-break-after for rows. > > The code that performs child break value propagation in > MovePastBreakpoint() was moved to the builder, and it is run > whenever the new flag is set to true. > > This fixed a bug where we failed to propagate up the break values of > a child if there was no BFC block-offset. The reason was that we > never called BreakBeforeChildIfNeeded() in that case. By moving the > propagation to the builder, instead, we can ensure the break values > are correctly propagated in this case, as well. > > Bug: 829028,1293291 > Change-Id: I2afd288cad99d11a1c414aca5844d7a77afef46f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3433832 > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Alison Maher <almaher@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#969018} Bug: 829028,1293291 Change-Id: I8f98930d65b0e9fd46e29d67c530ce72f204e2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3451309 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#969278}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!