| commit | aac2d58752e99ccc3469e2abe40bf5957ae055a1 | [log] [tgz] |
|---|---|---|
| author | jjgriego <84215144+jjgriego@users.noreply.github.com> | Mon Apr 04 15:03:46 2022 |
| committer | GitHub <noreply@github.com> | Mon Apr 04 15:03:46 2022 |
| tree | db5b3684c06f3dbc562cbcf1ab3af73bdbc8a6d5 | |
| parent | e7c65660d5183d41a1c1330f9615f40dbe6f447e [diff] |
Add `shadowrealm` support in testharness.js (#33162) * Add `shadowrealm` support in testharness.js This commit adds support to run `any.js` tests in Shadow Realm (https://github.com/tc39/proposal-shadowrealm) contexts-- Shadow realms are a new sandboxing primitive, currently a state 3 proposal in TC39 and in the process of being integrated into relevant Web specifications; part of this extends some computational-only Web interfaces to shadow realms (which otherwise do not have browser APIs and more closely resemble a vanilla JS shell environment.) I think it makes sense to extend WPT tests for these interfaces to also run in shadow realm contexts, so we can be assured they still work there. --- To accomplish this, I add a new `ShadowRealmTestEnvironment` to `testharness.js` that reuses the existing machinery to run tests remotely in e.g. dedicated workers. There are however, two main differences: - Shadow realms are not DOM contexts and so have no `onload` or similar event for us to use to actually begin test aggregation; instead, I add a new hook for the incubating realm to directly call to signal that all desired tests have been loaded. - The actual message port used to communicate test results back to a `RemoteContext` requires JSON-serialization of the mesasges (primitive values and callables may cross between a shadow- and incubating realm, but not arbitrary objects): it *happens* that this works correctly given the current encodings of Test, harness state, etc. are JSON-round-trippable, but this would become a hard requirement from this point forward. --- There's also one loose end at present: it's unclear (to me) given the current state of the way Shadow Realms are integrated into the HTML spec how we might be able to deal with unhandled promise rejections. It happens, for now, that they will be handed by the incubating `Window`'s `unhandledrejection` handler, which is installed by the parent test harness, and prints to the console. This seems acceptable for the time being, but may need to change as the spec is clarified. * Fix style + typo
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune (or git fetch -p && git merge).
See the documentation website and in particular the system setup for running tests locally.
The wpt command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve - For starting the wpt http serverwpt run - For running tests in a browserwpt lint - For running the lint against all testswpt manifest - For updating or generating a MANIFEST.json test manifestwpt install - For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave - For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt commands must be prefixed with python or the path to the python binary (if python is not in your %PATH%).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic../wpt lint as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!