commit | cad9fcc322e430a7be43e1ef72d685bf516ec46f | [log] [tgz] |
---|---|---|
author | Manuel Rego Casasnovas <rego@igalia.com> | Mon Mar 28 13:57:00 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Mar 28 14:14:57 2022 |
tree | f2f04b7d7beb0da8c4f175dd187fd77ac5db42c6 | |
parent | 295686cb45a01f109a53aa68b7d9a9e16964481f [diff] |
[css-pseudo] Implement behavior of color:currentcolor in highlights Right now we treat color:currentcolor as inherit for highlight pseudos, but it should use the same color than if that highlight didn't exist (so if it's the only one like if the text is not highlighted, otherwise like the text in the highlight under this). This patch adds a new ComputedStyle flag called ColorIsCurrentColor, that we set to true or false if color should behave as currentcolor for highlight pseudos. We use that information in HighlightPaintingUtils to decide the color to paint the color and background-color of highlight pseudos. This patch makes that the new test behaves the same with and without HighlightInheritance runtime flag enabled. There are some improvements in highlight-painting-currentcolor-001.html test, but other properties need to be adapted (like we're doing with background-color in this patch) in follow-up patches. So far we're always using the color of the originating text, that's why highlight-painting-currentcolor-002.html doesn't improve. This is because we need the new algorithm to paint highlight overlays (HighlightOverlayPainting flag) to know the right color we have to use in each case. There are TODOs in the code to fix this in follow-up patches. The new tests fail due to the double painting issues (crbug.com/1179938) that will get also fixed by HighlightOverlayPainting flag. Bug: 1295264 Test: external/wpt/css/css-pseudo/highlight-painting-currentcolor-003.html Test: external/wpt/css/css-pseudo/highlight-painting-currentcolor-004.html Change-Id: Ic95455301ed991a423a03eee02f3324cd1982e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3506351 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Delan Azabani <dazabani@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/main@{#985936}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!