commit | 77c4c81917a3258ddbde4f2d2dbd7bc070db7343 | [log] [tgz] |
---|---|---|
author | Delan Azabani <dazabani@igalia.com> | Thu Apr 21 12:33:13 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Apr 21 12:45:45 2022 |
tree | 46728fcef2c5a60357562e78d5560639d92be375 | |
parent | 0facbec3828b7a0cfe79125beaeed3ccb6982aec [diff] |
CSS highlight inheritance: optimise content with universal rules Virtually all existing content uses only universal highlight rules such as *::selection. Like all universal rules, this is inefficient because any savings from copy-on-write field inheritance get blown away when we reapply the same property values over and over. This wasn’t so bad prior to HighlightInheritance, because highlight styles were computed (a) lazily, and (b) only in “leaf” elements that directly contain highlighted text nodes. On a release build, adding a *::selection rule to a deeply nested test page used no more memory if nothing was selected, and ~79 MiB more if everything was selected. But with highlight inheritance, adding the same rule used ~132 MiB more memory at all times, even if nothing was selected [1]. This patch adds DidMatchNonUniversalHighlights, a ComputedStyle extra field that indicates whether any non-universal highlight rules matched while resolving the current highlight styles. The flag is inherently per-highlight-pseudo, because it’s set in the highlight ComputedStyle. If both parent and child match only universal highlight rules, then we skip reapplying the matched properties. [1] https://crbug.com/1024156#c16 Bug: 1024156 Change-Id: I65ece030140648f9e86d3c409251e13b3f111039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3581515 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/main@{#994624}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!