commit | 65f64fb581c54fba80fd929a4f153eb7cb9b585a | [log] [tgz] |
---|---|---|
author | Alison Maher <almaher@microsoft.com> | Tue Apr 19 15:57:21 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Apr 19 16:10:52 2022 |
tree | 7329ed661553534cad7d074647163f5fea8ccd61 | |
parent | 6a001e60711ce310af44e2c04280919ecc1e36a6 [diff] |
[LayoutNG] Nested fixedpos offset in multicol with inline CB As a follow-up to CL:3573056, add some ref tests for nested fixedpos elements with an inline container to ensure the correct offsets are applied. The following changes were made to ensure the offsets are correct in this case: 1. When we adjust the OOF container offsets in the box builder, we can't skip if the current node isn't a fixedpos container. The reason being that for inline CBs, the OOF containing block is set to the closest parent block flow of the inline. We want to make sure to adjust the offsets in this case, as well. 2. Subtract out the relative offset of the inline container from the static position of the fixedpos to ensure that the relative offset is applied after fragmentation. 3. If the OOF ancestor of the fixedpos has the same inline CB as the fixedpos, we would fail to find the CB for the fixedpos. This caused out-of-flow-in-multicolumn-089.html to crash. To fix this, update AdjustFixedposContainerInfo() to also look at the current inline container to see if that should be the fixedpos_inline_container, as well. Bug: 1312790 Change-Id: I831c80a401594bbf9426c083416e04d9a744aae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3587273 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#993723}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!